TST: resample does not yield empty groups (#10603) #35799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
suggested changes
Aug 20, 2020
| def test_resample_timedelta_no_empty_groups(): | ||
| # GH 10603 | ||
| # check that resample does not yield empty groups | ||
| df = pd.DataFrame(np.random.normal(size=(10000, 4))) |
There was a problem hiding this comment.
define df in a single step: pd.DataFrame(..., index=...)
| df.index = pd.timedelta_range(start="0s", periods=10000, freq="3906250n") | ||
| result = df.loc["1s":, :].resample("3s").apply(lambda x: len(x)) | ||
|
|
||
| expected = pd.DataFrame([[768.0] * 4] * 12 + [[528.0] * 4]) |
|
|
||
| def test_resample_timedelta_no_empty_groups(): | ||
| # GH 10603 | ||
| # check that resample does not yield empty groups |
There was a problem hiding this comment.
nit-pick: this comment is maybe spurious
| @@ -150,3 +150,15 @@ def test_resample_timedelta_edge_case(start, end, freq, resample_freq): | |||
| tm.assert_index_equal(result.index, expected_index) | |||
| assert result.index.freq == expected_index.freq | |||
| assert not np.isnan(result[-1]) | |||
|
|
|||
|
|
|||
| def test_resample_timedelta_no_empty_groups(): | |||
There was a problem hiding this comment.
nit-pick: test_resample_with_timedelta_yields_no_empty_groups
Just to make it easier to tell what the test does if we see it failing
tkmz-n
force-pushed
the
test-resample-empty-groups
branch
from
a731549 to
aba2a1f
Compare
arw2019
approved these changes
Aug 20, 2020
|
If you merge master CI failures should be resolved |
jreback
added
Missing-data
|
thanks @tkmz-n very nice |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Aug 22, 2020
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Aug 23, 2020
mroeschke
pushed a commit
that referenced
this pull request
Aug 31, 2020
* REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (#35630) * TST: resample does not yield empty groups (#10603) (#35799) * revert accidental rebase * REF: use BlockManager.apply for Rolling.count Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Aug 31, 2020
* REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (pandas-dev#35630) * TST: resample does not yield empty groups (pandas-dev#10603) (pandas-dev#35799) * revert accidental rebase * REF: use BlockManager.apply for Rolling.count Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
jreback
pushed a commit
that referenced
this pull request
Sep 2, 2020
…ce (#35899) * REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (#35630) * TST: resample does not yield empty groups (#10603) (#35799) * revert accidental rebase * REF: handle axis=None cases inside DataFrame.all/any * annotate * dummy commit to force Travis Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
jreback
pushed a commit
that referenced
this pull request
Sep 2, 2020
* REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (#35630) * TST: resample does not yield empty groups (#10603) (#35799) * revert accidental rebase * BUG: BlockSlider not clearing index._cache * update whatsnew Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
jreback
pushed a commit
that referenced
this pull request
Sep 2, 2020
…36045) * REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (#35630) * TST: resample does not yield empty groups (#10603) (#35799) * revert accidental rebase * BUG: NDFrame.replace wrong exception type, wrong return when size==0 * bool->bool_t * whatsnew Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (pandas-dev#35630) * TST: resample does not yield empty groups (pandas-dev#10603) (pandas-dev#35799) * revert accidental rebase * REF: use BlockManager.apply for Rolling.count Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…ce (pandas-dev#35899) * REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (pandas-dev#35630) * TST: resample does not yield empty groups (pandas-dev#10603) (pandas-dev#35799) * revert accidental rebase * REF: handle axis=None cases inside DataFrame.all/any * annotate * dummy commit to force Travis Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (pandas-dev#35630) * TST: resample does not yield empty groups (pandas-dev#10603) (pandas-dev#35799) * revert accidental rebase * BUG: BlockSlider not clearing index._cache * update whatsnew Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…andas-dev#36045) * REF: remove unnecesary try/except * TST: add test for agg on ordered categorical cols (pandas-dev#35630) * TST: resample does not yield empty groups (pandas-dev#10603) (pandas-dev#35799) * revert accidental rebase * BUG: NDFrame.replace wrong exception type, wrong return when size==0 * bool->bool_t * whatsnew Co-authored-by: Karthik Mathur <[email protected]> Co-authored-by: tkmz-n <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis adds a test to verify that resample does not yield empty groups.
I'm new to contributing to pandas, and I'm not sure where to add this test.
Let me know if this place is inappropriate.